mrproliu commented on a change in pull request #68:
URL:
https://github.com/apache/skywalking-satellite/pull/68#discussion_r714058938
##########
File path: plugins/client/grpc/client.go
##########
@@ -100,8 +102,15 @@ func (c *Client) Prepare() error {
"client_name": Name,
})})
+ // server address resolver
+ resolvers.RegisterAllGrpcResolvers()
+
// connect to server
- client, err := grpc.Dial(c.ServerAddr, *cfg...)
+ target, err := resolvers.BuildTarget(&c.ServerFinderConfig)
Review comment:
Yes, For the k8s case, there just save the Kubernetes pod/service
config(by label selector), not include real address config. The static address
config is a special case because we just need to specify the address list.
We use resolver to update the server address list. Please take a look on:
https://github.com/apache/skywalking-satellite/pull/68/files#diff-31cdd706c94e7a14dab4bf57861b31fc5b7e919d946fd480c593f3f18f8aafd4R69-R76
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
