kezhenxu94 commented on a change in pull request #62:
URL:
https://github.com/apache/skywalking-infra-e2e/pull/62#discussion_r738867127
##########
File path: docs/en/setup/Configuration-File.md
##########
@@ -123,6 +127,10 @@ If you want to get the service host and port mapping,
should follow these steps:
url: http://${oap_host}:${oap_8080}/
```
+#### Log
+
+The console output of each pod will be saved after startup. File address:
`${workDir}/logs/{serviceName}/std.log`
Review comment:
```suggestion
The console output of each service will be saved after startup. File
address: `${workDir}/logs/{serviceName}/std.log`
```
##########
File path: docs/en/setup/Run-E2E-Tests.md
##########
@@ -31,9 +31,11 @@ e2e cleanup
To use skywalking-infra-e2e in GitHub Actions, add a step in your GitHub
workflow.
+The working directory is uploaded to GitHub Action Artifact after the task is
completed, which contains environment variables and container logs in the
environment.
Review comment:
Reword this after you add an option to the GHA and disable it by default
##########
File path: action.yaml
##########
@@ -31,4 +31,9 @@ runs:
docker run -v $(pwd):/tmp -w /tmp --entrypoint=sh
docker.io/apache/e2e:latest -c "cp /usr/local/bin/e2e /tmp/e2e"
install ./e2e /usr/local/bin
- shell: bash
- run: e2e run -c "${{ inputs.e2e-file }}"
+ run: e2e run -c "${{ inputs.e2e-file }}" -w "${{ runner.temp
}}/skywalking-infra-e2e"
+ - name: Upload Work Directory
+ uses: actions/upload-artifact@v2
+ with:
+ name: skywalking-infra-e2e
+ path: ${{ runner.temp }}/skywalking-infra-e2e
Review comment:
Don't hardcode this, please disable it by default, it consumes user's
GitHub storage budget. Add an `input` (`save-logs`) to enable this instead
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
