kezhenxu94 commented on pull request #62:
URL:
https://github.com/apache/skywalking-infra-e2e/pull/62#issuecomment-954442941
> I notice the `job_id` could not be found in GitHub Action Environment or
Context. If we could get the `job_id`, then we could query the API to get the
job name.
i don’t think it a good idea to invoke GitHub API in this e2e tool. And
where will you do the query to get the job name?
> Should we generated my job name with matrix, such as:
`${{github.job}}_$(echo '${{ toJSON(matrix) }}'|jq -r
'to_entries|map(.value)|join("_")')`, It's similar to the real job name. WDYT?
You can, but job name is not what we should care about here. The user can
set whatever job name they like, we should not force them to set it like this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
