wu-sheng commented on a change in pull request #8035:
URL: https://github.com/apache/skywalking/pull/8035#discussion_r738981369
##########
File path:
oap-server/server-starter/src/main/java/org/apache/skywalking/oap/server/starter/config/ApplicationConfigLoader.java
##########
@@ -125,6 +126,20 @@ private void replacePropertyAndLog(final Object
propertyName, final Object prope
}
}
+ private Object convertValueString(String valueString) {
+ try {
+ Object replaceValue = yaml.load(valueString);
+ if (replaceValue instanceof String || replaceValue instanceof
Integer || replaceValue instanceof Long || replaceValue instanceof Boolean ||
replaceValue instanceof ArrayList) {
+ return replaceValue;
+ } else {
+ return valueString;
+ }
Review comment:
I can't see what is the case following into this `else`, could you
explain a little?
Also, I can't see the case relating to the error case you reported. Could
you add it there too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
