wu-sheng commented on a change in pull request #8035:
URL: https://github.com/apache/skywalking/pull/8035#discussion_r739061080
##########
File path:
oap-server/server-starter/src/main/java/org/apache/skywalking/oap/server/starter/config/ApplicationConfigLoader.java
##########
@@ -125,6 +126,20 @@ private void replacePropertyAndLog(final Object
propertyName, final Object prope
}
}
+ private Object convertValueString(String valueString) {
+ try {
+ Object replaceValue = yaml.load(valueString);
+ if (replaceValue instanceof String || replaceValue instanceof
Integer || replaceValue instanceof Long || replaceValue instanceof Boolean ||
replaceValue instanceof ArrayList) {
+ return replaceValue;
+ } else {
+ return valueString;
+ }
Review comment:
But `animal: pets` isn't supported for the core or extension, isn't it?
If so, we should throw exception here rather than returning an unsupported
value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
