wu-sheng commented on a change in pull request #7766:
URL: https://github.com/apache/skywalking/pull/7766#discussion_r742502661



##########
File path: tools/dependencies/known-oap-backend-dependencies.txt
##########
@@ -89,12 +98,16 @@ jsr305-3.0.2.jar
 kafka-clients-2.4.1.jar
 kotlin-reflect-1.1.1.jar
 kotlin-stdlib-1.1.60.jar
+libthrift-0.14.1.jar
 listenablefuture-9999.0-empty-to-avoid-conflict-with-guava.jar
 log4j-api-2.14.1.jar
 log4j-core-2.14.1.jar
 log4j-over-slf4j-1.7.30.jar
 log4j-slf4j-impl-2.14.1.jar
+logback-classic-1.2.3.jar
+logback-core-1.2.3.jar
 logging-interceptor-3.13.1.jar
+lz4-1.3.0.jar
 lz4-java-1.6.0.jar

Review comment:
       OMG, these are 2 different libs. :(
   
   - https://github.com/lz4/lz4
   - https://github.com/lz4/lz4-java




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to