wu-sheng commented on a change in pull request #7766:
URL: https://github.com/apache/skywalking/pull/7766#discussion_r742805724



##########
File path: tools/dependencies/known-oap-backend-dependencies.txt
##########
@@ -61,17 +61,26 @@ httpclient-4.5.13.jar
 httpcore-4.4.13.jar
 httpcore-nio-4.4.13.jar
 influxdb-java-2.15.jar
+iotdb-session-0.13.0-SNAPSHOT.jar
+iotdb-thrift-0.13.0-SNAPSHOT.jar
+istack-commons-runtime-4.0.0.jar
 jackson-annotations-2.12.2.jar
 jackson-core-2.12.2.jar
 jackson-databind-2.12.2.jar
 jackson-datatype-guava-2.9.10.jar
 jackson-datatype-jdk8-2.9.10.jar
 jackson-module-afterburner-2.12.2.jar
 jackson-module-kotlin-2.8.8.jar
+jakarta.activation-2.0.0.jar
+jakarta.xml.bind-api-3.0.0.jar

Review comment:
       FYI @kezhenxu94 I think our maven cache may cause some issues when we 
use `SNAPSHOT` for draft PR.
   
   
![image](https://user-images.githubusercontent.com/5441976/140316608-3007b1a0-91e5-4cc0-a0ee-867ccfef8eff.png)
   
   I and @LIU-WEI-git both packaged locally, these jars exist, but CI checks on 
dependencies say otherwise.
   ```
   @@ -74,2 +72,0 @@
   -jakarta.activation-2.0.0.jar
   -jakarta.xml.bind-api-3.0.0.jar
   ```
   
   I don't think we have to fix this, as we never would accept a PR using 
snapshot dependency. Just find out this curious case.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to