hanahmily commented on a change in pull request #83:
URL:
https://github.com/apache/skywalking-kubernetes/pull/83#discussion_r755796492
##########
File path: chart/skywalking/templates/oap-clusterrolebinding.yaml
##########
@@ -31,4 +31,9 @@ subjects:
- kind: ServiceAccount
name: {{ template "skywalking.serviceAccountName.oap" . }}
namespace: {{ .Release.Namespace }}
+{{- if .Values.satellite.enabled }}
Review comment:
From the oap and satellite's manifests, they would be in the same
namespace, which means a role with getting/listing pods is enough to satellite
instead of a cluster role.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
