kezhenxu94 commented on a change in pull request #83:
URL:
https://github.com/apache/skywalking-kubernetes/pull/83#discussion_r755898474
##########
File path: .github/workflows/e2e.ci.yaml
##########
@@ -43,98 +46,29 @@ jobs:
repository: apache/skywalking
submodules: true
path: main
- ref: 6228d450e1b0792dd9875ad68984c89c81ece742
+ ref: 8436135dc919351a6d0ab42ff48c85e1b3104b53
Review comment:
OK if that's the case, it means you cannot run the tests locally without
manually cloning/copying the main repo to a specific location, I'd rather copy
those files or put the `checkout` step into the `e2e.yaml`.
Also, you cannot simply use `OAP_TAG: latest` (line 30) and `UI_TAG: latest`
(line 32) when you use a specific revision of the expected files, they might
break in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
