wu-sheng commented on a change in pull request #83:
URL:
https://github.com/apache/skywalking-kubernetes/pull/83#discussion_r757189317
##########
File path: .github/workflows/e2e.ci.yaml
##########
@@ -27,9 +27,12 @@ on:
env:
SKIP_TEST: true
ISTIO_VERSION: 1.7.1
- TAG: ${{ github.sha }}
- SCRIPTS_DIR: main/test/e2e-mesh/e2e-istio/scripts
- SW_OAP_BASE_IMAGE: openjdk:8-jre-alpine
+ OAP_TAG: cef4f6dcac5b14cd67f51a64ad08052bbc046653
+ OAP_REPO: ghcr.io/apache/skywalking/oap
+ UI_TAG: cef4f6dcac5b14cd67f51a64ad08052bbc046653
+ UI_REPO: ghcr.io/apache/skywalking/ui
+ SATELLITE_TAG: v64f1938e118e95b8d8f50756f666e4777ce6aca2
+ SATELLITE_REPO: ghcr.io/apache/skywalking-satellite/skywalking-satellite
Review comment:
I think the point is where we define the tags. If repositories are
expected to reused in other e2e, then it is better to move together.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
