tedli commented on pull request #73: URL: https://github.com/apache/skywalking-java/pull/73#issuecomment-987712730
Hi, @wu-sheng FYI https://github.com/apache/dubbo/blob/00ca43643d243f0866389abd294c6160e155c8a5/dubbo-monitor/dubbo-monitor-api/src/main/java/org/apache/dubbo/monitor/support/MonitorFilter.java#L54-L55 https://github.com/apache/dubbo/blob/5a5e3f3fd7d0482b6124bd5b52b10f4900856438/dubbo-monitor/dubbo-monitor-api/src/main/java/org/apache/dubbo/monitor/support/MonitorFilter.java#L52-L53 ```java // dubbo 2.7.x @Activate(group = {PROVIDER, CONSUMER}) public class MonitorFilter implements Filter, Filter.Listener { } // dubbo 3.x @Activate(group = {PROVIDER}) public class MonitorFilter implements Filter, Filter.Listener { } ``` After some debugging, I found out why the scenario test of dubbo3 failed, it's because the occasion that `MonitorFilter` takes place is different in dubbo 3.x from 2.7.x, only provider side produced spans. So the test failed. It need to find other filters to adjust instrumentation class intercepting behavior, so that consumer side can also produce spans. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
