tedli edited a comment on pull request #73:
URL: https://github.com/apache/skywalking-java/pull/73#issuecomment-986607019
> @tedli Any luck with this plugin?
Hi, the witness methods works fine, by adding witness methods like this:
```java
// dubbo 2.7.x
@Override
protected List<WitnessMethod> witnessMethods() {
return Collections.singletonList(new WitnessMethod(
"org.apache.dubbo.rpc.RpcContext",
named("getServerContext").and(returns(named("org.apache.dubbo.rpc.RpcContext")))));
}
// dubbo 3.x
@Override
protected List<WitnessMethod> witnessMethods() {
return Collections.singletonList(new WitnessMethod(
"org.apache.dubbo.rpc.RpcContext",
named("getServerContext").and(returns(named("org.apache.dubbo.rpc.RpcContextAttachment")))));
}
```
the agent mechanism accurately load the correct plugin. And the scenario
test of 2.7.x passed as it is.
How ever the scenario test of 3 still failed, ~~it because `request url` got
from `invocation` seemed weird~~, the produced span didn't match the expect
value.
It need some further investigation about how to construct a span for dubbo
3.
:sob: It's the end of the year, I have to handle some of my own mess, which
has higher priority. I'm very glad to continue working on this issue. I will
make some time for this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
