kezhenxu94 commented on a change in pull request #73:
URL: https://github.com/apache/skywalking-java/pull/73#discussion_r766282619
##########
File path:
apm-sniffer/apm-sdk-plugin/dubbo-2.7.x-conflict-patch/src/main/java/org/apache/skywalking/apm/plugin/asf/dubbo/patch/WrapperInstrumentation.java
##########
@@ -35,30 +40,44 @@
* to ensure the correct compilation of the code.
*/
public class WrapperInstrumentation extends
ClassStaticMethodsEnhancePluginDefine {
+
+ private static final String CONTEXT_TYPE_NAME =
"org.apache.dubbo.rpc.RpcContext";
+
+ private static final String GET_SERVER_CONTEXT_METHOD_NAME =
"getServerContext";
+
@Override
public StaticMethodsInterceptPoint[] getStaticMethodsInterceptPoints() {
- return new StaticMethodsInterceptPoint[] {
- new StaticMethodsInterceptPoint() {
- @Override
- public ElementMatcher<MethodDescription> getMethodsMatcher() {
- return named("makeWrapper");
- }
+ return new StaticMethodsInterceptPoint[]{
+ new StaticMethodsInterceptPoint() {
+ @Override
+ public ElementMatcher<MethodDescription>
getMethodsMatcher() {
+ return named("makeWrapper");
+ }
- @Override
- public String getMethodsInterceptor() {
- return
"org.apache.skywalking.apm.plugin.asf.dubbo.patch.MakeWrapperInterceptor";
- }
+ @Override
+ public String getMethodsInterceptor() {
+ return
"org.apache.skywalking.apm.plugin.asf.dubbo.patch.MakeWrapperInterceptor";
+ }
- @Override
- public boolean isOverrideArgs() {
- return false;
+ @Override
+ public boolean isOverrideArgs() {
+ return false;
+ }
Review comment:
These are irrelevant changes, can you import our code style settings and
reformat the codes, including the other new files and changes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
