mrproliu commented on a change in pull request #8716:
URL: https://github.com/apache/skywalking/pull/8716#discussion_r831192390
##########
File path:
oap-server/server-storage-plugin/storage-elasticsearch-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/elasticsearch/query/MetadataQueryEsDAO.java
##########
@@ -230,6 +230,17 @@ public Process getProcess(String processId) throws
IOException {
return processes.isEmpty() ? null : processes.get(0);
}
+ @Override
+ public List<Process> getProcesses(List<String> processIdList) throws
IOException {
Review comment:
Use that means I need to re-create `IMetricsDAO` by
`StorageDAO#newMetricsDao`, and re-mapping `ProcessTraffic` to
`Process`(graphql). Currently, we already have storage in graphQL logic, so I
just keep the `Process` created in one place. Should I change it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
