wu-sheng commented on a change in pull request #8716:
URL: https://github.com/apache/skywalking/pull/8716#discussion_r831212474
##########
File path:
oap-server/server-storage-plugin/storage-elasticsearch-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/elasticsearch/query/MetadataQueryEsDAO.java
##########
@@ -230,6 +230,17 @@ public Process getProcess(String processId) throws
IOException {
return processes.isEmpty() ? null : processes.get(0);
}
+ @Override
+ public List<Process> getProcesses(List<String> processIdList) throws
IOException {
Review comment:
Yes, I know we have to re-create those objects, but new interfaces mean
we are adding more and more burdens to the storage level, which have N
implementations. Let's not do that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
