kezhenxu94 commented on a change in pull request #3170: Support upgrade backend
w/o rebooting agents
URL: https://github.com/apache/skywalking/pull/3170#discussion_r307961597
##########
File path:
apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/remote/GRPCChannelManager.java
##########
@@ -88,24 +88,22 @@ public void run() {
String server = "";
try {
int index = Math.abs(random.nextInt()) %
grpcServers.size();
- if (index != selectedIdx) {
- selectedIdx = index;
+ selectedIdx = index;
Review comment:
Most of the components (such as `ServiceAndEndpointRegisterClient`) depend
on the status change callback
`org.apache.skywalking.apm.agent.core.remote.GRPCChannelListener#statusChanged`
(triggered by `notify` line 106), if there is only one OAP node and it's
restarting, the status would be `DISCONNECTED` and never change back to
`CONNECTED`, all the components depends on the status won't work since then
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
