kezhenxu94 commented on a change in pull request #3170: Support upgrade backend
w/o rebooting agents
URL: https://github.com/apache/skywalking/pull/3170#discussion_r308044778
##########
File path:
oap-server/server-storage-plugin/storage-jdbc-hikaricp-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/jdbc/h2/dao/H2NetworkAddressInventoryCacheDAO.java
##########
@@ -63,7 +63,7 @@ public H2NetworkAddressInventoryCacheDAO(JDBCHikariCPClient
h2Client) {
try (ResultSet resultSet = h2Client.executeQuery(connection,
sql.toString(), lastUpdateTime)) {
NetworkAddressInventory addressInventory;
do {
- addressInventory =
(NetworkAddressInventory)toStorageData(resultSet,
NetworkAddressInventory.INDEX_NAME, new ServiceInventory.Builder());
+ addressInventory =
(NetworkAddressInventory)toStorageData(resultSet,
NetworkAddressInventory.INDEX_NAME, new NetworkAddressInventory.Builder());
Review comment:
> This bug should be merged quickly. Could you send another PR to fix?
Yes, I'll send a fix PR soon
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
