pg-yang commented on code in PR #9622: URL: https://github.com/apache/skywalking/pull/9622#discussion_r973576392
########## oap-server/server-starter/src/main/resources/ui-initialized-templates/virtual_cache/virtual-cache-root.json: ########## @@ -0,0 +1,122 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +[ + { + "id": "Virtual-Cache-Root", + "configuration": { + "children": [ + { + "x": 0, + "y": 2, + "w": 24, + "h": 52, + "i": "0", + "type": "Widget", + "widget": { + "title": "Virtual Cache" + }, + "graph": { + "type": "ServiceList", + "dashboardName": "Virtual-Cache-Service", + "fontSize": 12, + "showXAxis": false, + "showYAxis": false, + "showGroup": false + }, + "metrics": [ + "cache_read_resp_time", + "cache_read_sla", + "cache_read_cpm", + "cache_write_resp_time", + "cache_write_sla", + "cache_write_cpm" + ], + "metricTypes": [ + "readMetricsValues", + "readMetricsValues", + "readMetricsValues", + "readMetricsValues", + "readMetricsValues", + "readMetricsValues" + ], + "moved": false, + "metricConfig": [ + { + "unit": "ms", + "label": "Read Latency", + "calculation": "average" + }, + { + "label": "Successful Read Rate", + "unit": "%", + "calculation": "percentageAvg" + }, + { + "label": "Read Traffic", + "unit": "calls / min", + "calculation": "average" + }, + { + "unit": "ms", + "label": "Write Latency", + "calculation": "average" + }, + { + "label": "Successful Write Rate", + "unit": "%", + "calculation": "percentageAvg" + }, + { + "label": "Write Traffic", + "unit": "calls / min", + "calculation": "average" + } + ] + }, + { + "x": 0, + "y": 0, + "w": 24, + "h": 2, + "i": "100", + "type": "Text", + "metricTypes": [ + "" + ], + "metrics": [ + "" + ], + "graph": { + "fontColor": "blue", + "backgroundColor": "white", + "content": "Observe the Virtual Cache which is conjectured by language agent through various plugins.", + "fontSize": 14, + "textAlign": "left", + "url": "https://skywalking.apache.org/docs/main/latest/en/setup/service-agent/virtual-cache/"; + }, + "moved": false + } + ], + "id": "Virtual-Cache-Root", + "layer": "VIRTUAL_CACHE", + "entity": "All", + "name": "Virtual-Cache-Root", + "isRoot": true Review Comment: The UI code I updated:  The screenshot   ########## docs/menu.yml: ########## @@ -111,6 +111,8 @@ catalog: path: "/en/setup/backend/trace-sampling" - name: "Detect Slow Database Statement" path: "/en/setup/backend/slow-db-statement" + - name: "Detect Slow Database Statement" Review Comment: Will be done ########## oap-server/analyzer/agent-analyzer/src/main/java/org/apache/skywalking/oap/server/analyzer/provider/AnalyzerModuleConfig.java: ########## @@ -60,6 +62,23 @@ public class AnalyzerModuleConfig extends ModuleConfig { @Setter @Getter private DBLatencyThresholdsAndWatcher dbLatencyThresholdsAndWatcher; + + @Setter + @Getter + private String slowCacheWriteThreshold = "default:20"; + + @Setter + @Getter + private CacheWriteLatencyThresholdsAndWatcher cacheWriteLatencyThresholdsAndWatcher; + + @Setter + @Getter + private String slowCacheReadThreshold = "default:20"; + + @Setter + @Getter + private CacheReadLatencyThresholdsAndWatcher cacheReadLatencyThresholdsAndWatcher; Review Comment: Will be done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
