pg-yang commented on code in PR #9622:
URL: https://github.com/apache/skywalking/pull/9622#discussion_r973173857
##########
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/source/DefaultScopeDefine.java:
##########
@@ -163,18 +168,18 @@ private static final void addNewScope(ScopeDeclaration
declaration, Class origin
int id = declaration.id();
if (ID_2_NAME.containsKey(id)) {
throw new UnexpectedException(
- "ScopeDeclaration id=" + id + " at " + originalClass.getName()
+ " has conflict with another named " + ID_2_NAME
- .get(id));
+ "ScopeDeclaration id=" + id + " at " +
originalClass.getName() + " has conflict with another named " + ID_2_NAME
+ .get(id));
Review Comment:
Could you help me to set appropriate format settings ? Maybe provide me a
doc or an exported settings .
I'm pained for the setting ,Thanks
##########
test/e2e-v2/cases/storage/storage-cases.yaml:
##########
@@ -47,7 +47,7 @@ cases:
- query: swctl --display yaml
--base-url=http://${oap_host}:${oap_12800}/graphql trace ls
expected: expected/traces-list.yml
# negative tags search: relationship should be logical AND instead of
logical OR
- - query: swctl --display yaml
--base-url=http://${oap_host}:${oap_12800}/graphql trace ls --tags
http.method=POST,http.status_code=200
+ - query: swctl --display yaml
--base-url=http://${oap_host}:${oap_12800}/graphql trace ls --tags
http.method=POST,http.status_code=200,iserror=true
Review Comment:
I don't know why use negative tags search , In order to keep this query
negative , I added the query param .
Because the latest java agent collect all status_code ,but previous agent
collect the status_code which max than 400 .
You could find this PR https://github.com/apache/skywalking-java/pull/258
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
