pg-yang commented on PR #9725:
URL: https://github.com/apache/skywalking/pull/9725#issuecomment-1265635426
> * Is there any real case about no `node`? That seems a bug rather than a
metric.
Not bug , APISIX prometheus doc show the describe such as `route_id of
the matched Route with request. Defaults to an empty string if the Routes don't
match.` .
Currently only 404 in gateway level could produce empty node/route , my
local test data :
```
apisix_bandwidth{type="egress",route="",service="",consumer="",node=""}
364000
apisix_bandwidth{type="egress",route="routes#1",service="1",consumer="",node="172.18.0.3"}
682000
apisix_bandwidth{type="egress",route="routes#3",service="3",consumer="",node=""}
764000
apisix_bandwidth{type="ingress",route="",service="",consumer="",node=""}
192000
apisix_bandwidth{type="ingress",route="routes#1",service="1",consumer="",node="172.18.0.3"}
386000
apisix_bandwidth{type="ingress",route="routes#3",service="3",consumer="",node=""}
192000
# HELP apisix_http_status HTTP status codes per service in APISIX
# TYPE apisix_http_status counter
apisix_http_status{code="404",route="",matched_uri="",matched_host="",service="",consumer="",node=""}
2000
apisix_http_status{code="404",route="routes#1",matched_uri="/service-a/*",matched_host="",service="1",consumer="",node="172.18.0.3"}
2000
apisix_http_status{code="500",route="routes#1",matched_uri="/service-a/*",matched_host="",service="1",consumer="",node="172.18.0.3"}
2000
apisix_http_status{code="503",route="routes#3",matched_uri="/service-c/*",matched_host="",service="3",consumer="",node=""}
2000
```
> You could aggregate all not-null route and node metrics as the global one.
I would aggregate all metrics as global metrics , don't filter any tag .
> Showing the no route as the no route rule metrics
In no rule case, latency should be nano-sec rather than traditional ms. 1ms
is too slow for a request w/o route rule, right?
I would add a new metrics for displaying http status which request couldn't
match any route , name like `HTTP status (route mismatched)` . I think
displaying latency , bandwidth for invalid request is meaningless , `HTTP
status (route mismatched)` is enough to notice user
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
