wu-sheng commented on PR #9725: URL: https://github.com/apache/skywalking/pull/9725#issuecomment-1265658427
> Not bug , APISIX prometheus doc show the describe such as route_id of the matched Route with request. Defaults to an empty string if the Routes don't match. . Then this should be `Not matched route trend`. > I would aggregate all metrics as global metrics , don't filter any tag . You should filter to separate valid request(having matched route) and invalid request >I think displaying latency , bandwidth for invalid request is meaningless , HTTP status (route mismatched) is enough to notice user Actually, they are meaning full. They could show whether there is a serious DDoS(or similar) attack. Bandwidth is a serious cost even with low request load, as well as latency because high latency would mean the CPU of APISIX would be cost and used for the meaningless requests. > And changing latency unit from ms to nano-sec is not a good choice . because OpenTelemetryMetricHandler have already convert nano-sec to ms . But I guess it is a double, we are still safe to convert it back. We keep precision as integer, too quick response would always be **0**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
