pg-yang commented on PR #83:
URL:
https://github.com/apache/skywalking-showcase/pull/83#issuecomment-1275746888
> I mean, we should whether tag[service name] exists, if not, MAL should
fill in one, rather than keeping a blank name.
Got It ,and you have repeated it many times
> OK, as it is a static configuration, this seems strange. If you don't
config anything, they don't know there is a tag key
The attribute `service` has already used by apisix .
I would use `skywalking_service` as attribute name , it's more clear for
user , also could avoid conflict with other software
I would submit PR at tonight
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
