kezhenxu94 commented on code in PR #83:
URL: https://github.com/apache/skywalking-showcase/pull/83#discussion_r995231337
##########
deploy/platform/kubernetes/feature-cluster/resources.yaml:
##########
@@ -199,7 +199,8 @@ spec:
# @feature: kubernetes-monitor; enable rules to analyze
Kubernetes Cluster/Node/Service metrics
# @feature: istiod-monitor; enable rules to analyze Istio
control plane metrics
# @feature: mysql; enable mysql rules to analyze MySQL metrics
- value:
vm,oap,k8s-cluster,k8s-node,k8s-service,k8s-instance,istio-controlplane,mysql,postgresql
+ # @feature: APISIX; enable APISIX rules to analyze APISIX metrics
Review Comment:
Let's use the feature flag name
```suggestion
# @feature: apisix-monitor; enable APISIX rules to analyze
APISIX metrics
```
##########
deploy/platform/kubernetes/feature-cluster/resources.yaml:
##########
@@ -199,7 +199,8 @@ spec:
# @feature: kubernetes-monitor; enable rules to analyze
Kubernetes Cluster/Node/Service metrics
# @feature: istiod-monitor; enable rules to analyze Istio
control plane metrics
# @feature: mysql; enable mysql rules to analyze MySQL metrics
- value:
vm,oap,k8s-cluster,k8s-node,k8s-service,k8s-instance,istio-controlplane,mysql,postgresql
+ # @feature: APISIX; enable APISIX rules to analyze APISIX metrics
Review Comment:
Let's use the feature flag name
```suggestion
# @feature: apisix-monitor; enable APISIX rules to analyze
APISIX metrics
```
##########
deploy/platform/kubernetes/feature-apisix-monitor/resources.yaml:
##########
@@ -0,0 +1,104 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+
+apiVersion: v1
+kind: ConfigMap
+metadata:
+ name: otel-collector-conf-apisix
+ labels:
+ app: otel-apisix
+data:
+ otel-collector-config: |
+ receivers:
+ prometheus:
+ config:
+ scrape_configs:
+ - job_name: 'apisix-monitoring'
+ scrape_interval: 5s
+ metrics_path: "/apisix/prometheus/metrics"
+ kubernetes_sd_configs:
+ - role: pod
+ relabel_configs:
+ - source_labels: [__meta_kubernetes_pod_container_name,
__meta_kubernetes_pod_container_port_name]
+ action: keep
+ regex: frontend;metrics # @feature: apisix-monitor;
reference the name of the metrics port
+ - source_labels: [__meta_kubernetes_pod_name]
+ target_label: host_name
+ regex: (.+)
+ replacement: $$1
+ - target_label: skywalking_service
+ replacement: frontend
+ processors:
+ batch:
+ exporters:
+ otlp:
+ endpoint: oap:11800
Review Comment:
Can we use this
```suggestion
endpoint: ${BACKEND_SERVICE}:11800
```
##########
docs/readme.md:
##########
@@ -99,11 +101,12 @@ Currently, the features supported are:
| `rover` | Deploy SkyWalking Rover and detect the processes in
the Kubernetes environment.
| Only support deployment in the Kubernetes environment, docker is not
supported. |
| `mysql` | Start a MySQL server and load generator to execute
the sample SQLs periodically, set up fluent bit to fetch slow logs and export
to OAP, and export their metrics to SkyWalking.
|
|
| `postgresql` | Start a PostgreSQL server, and load generator to
execute the sample SQLs periodically, set up fluent bit to fetch slow logs and
export to OAP, and export their metrics to SkyWalking.
|
|
+| `apisix-monitor` | Deploy OpenTelemetry and export APISIX metrics
to SkyWalking for analysis and display on UI |
|
### Kubernetes
-To deploy the example application in Kubernetes, please make sure that you
have `kubectl` command available, and it can
-connect to the Kubernetes cluster successfully.
+To deploy the example application in Kubernetes, please make sure the version
lower than `v1.25` to support `CronJob`.
Review Comment:
Lower than `v1.25`? Maybe you mean higher than `v1.25`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
