pg-yang commented on code in PR #9813:
URL: https://github.com/apache/skywalking/pull/9813#discussion_r999083269


##########
oap-server/server-starter/src/main/resources/oal/core.oal:
##########
@@ -15,74 +15,4 @@
  * limitations under the License.
  *
  */
-
-// For services using protocols HTTP 1/2, gRPC, RPC, etc., the cpm metrics 
means "calls per minute",
-// for services that are built on top of TCP, the cpm means "packages per 
minute".
-
-// Service scope metrics
-service_resp_time = from(Service.latency).longAvg();
-service_sla = from(Service.*).percent(status == true);
-service_cpm = from(Service.*).cpm();
-service_percentile = from(Service.latency).percentile(10); // Multiple values 
including p50, p75, p90, p95, p99
-service_apdex = from(Service.latency).apdex(name, status);
-service_mq_consume_count = from(Service.*).filter(type == 
RequestType.MQ).count();
-service_mq_consume_latency = 
from((str->long)Service.tag["transmission.latency"]).filter(type == 
RequestType.MQ).filter(tag["transmission.latency"] != null).longAvg();
-
-// Service relation scope metrics for topology
-service_relation_client_cpm = from(ServiceRelation.*).filter(detectPoint == 
DetectPoint.CLIENT).cpm();
-service_relation_server_cpm = from(ServiceRelation.*).filter(detectPoint == 
DetectPoint.SERVER).cpm();
-service_relation_client_call_sla = from(ServiceRelation.*).filter(detectPoint 
== DetectPoint.CLIENT).percent(status == true);
-service_relation_server_call_sla = from(ServiceRelation.*).filter(detectPoint 
== DetectPoint.SERVER).percent(status == true);
-service_relation_client_resp_time = 
from(ServiceRelation.latency).filter(detectPoint == 
DetectPoint.CLIENT).longAvg();
-service_relation_server_resp_time = 
from(ServiceRelation.latency).filter(detectPoint == 
DetectPoint.SERVER).longAvg();
-service_relation_client_percentile = 
from(ServiceRelation.latency).filter(detectPoint == 
DetectPoint.CLIENT).percentile(10); // Multiple values including p50, p75, p90, 
p95, p99
-service_relation_server_percentile = 
from(ServiceRelation.latency).filter(detectPoint == 
DetectPoint.SERVER).percentile(10); // Multiple values including p50, p75, p90, 
p95, p99
-
-// Service Instance relation scope metrics for topology
-service_instance_relation_client_cpm = 
from(ServiceInstanceRelation.*).filter(detectPoint == DetectPoint.CLIENT).cpm();
-service_instance_relation_server_cpm = 
from(ServiceInstanceRelation.*).filter(detectPoint == DetectPoint.SERVER).cpm();
-service_instance_relation_client_call_sla = 
from(ServiceInstanceRelation.*).filter(detectPoint == 
DetectPoint.CLIENT).percent(status == true);
-service_instance_relation_server_call_sla = 
from(ServiceInstanceRelation.*).filter(detectPoint == 
DetectPoint.SERVER).percent(status == true);
-service_instance_relation_client_resp_time = 
from(ServiceInstanceRelation.latency).filter(detectPoint == 
DetectPoint.CLIENT).longAvg();
-service_instance_relation_server_resp_time = 
from(ServiceInstanceRelation.latency).filter(detectPoint == 
DetectPoint.SERVER).longAvg();
-service_instance_relation_client_percentile = 
from(ServiceInstanceRelation.latency).filter(detectPoint == 
DetectPoint.CLIENT).percentile(10); // Multiple values including p50, p75, p90, 
p95, p99
-service_instance_relation_server_percentile = 
from(ServiceInstanceRelation.latency).filter(detectPoint == 
DetectPoint.SERVER).percentile(10); // Multiple values including p50, p75, p90, 
p95, p99
-
-// Service Instance Scope metrics
-service_instance_sla = from(ServiceInstance.*).percent(status == true);
-service_instance_resp_time= from(ServiceInstance.latency).longAvg();
-service_instance_cpm = from(ServiceInstance.*).cpm();
-
-// Endpoint scope metrics
-endpoint_cpm = from(Endpoint.*).cpm();
-endpoint_resp_time = from(Endpoint.latency).longAvg();
-endpoint_sla = from(Endpoint.*).percent(status == true);
-endpoint_percentile = from(Endpoint.latency).percentile(10); // Multiple 
values including p50, p75, p90, p95, p99
-endpoint_mq_consume_count = from(Endpoint.*).filter(type == 
RequestType.MQ).count();
-endpoint_mq_consume_latency = 
from((str->long)Endpoint.tag["transmission.latency"]).filter(type == 
RequestType.MQ).filter(tag["transmission.latency"] != null).longAvg();
-
-// Endpoint relation scope metrics
-endpoint_relation_cpm = from(EndpointRelation.*).filter(detectPoint == 
DetectPoint.SERVER).cpm();
-endpoint_relation_resp_time = 
from(EndpointRelation.rpcLatency).filter(detectPoint == 
DetectPoint.SERVER).longAvg();
-endpoint_relation_sla = from(EndpointRelation.*).filter(detectPoint == 
DetectPoint.SERVER).percent(status == true);
-endpoint_relation_percentile = 
from(EndpointRelation.rpcLatency).filter(detectPoint == 
DetectPoint.SERVER).percentile(10); // Multiple values including p50, p75, p90, 
p95, p99
-
-database_access_resp_time = from(DatabaseAccess.latency).longAvg();
-database_access_sla = from(DatabaseAccess.*).percent(status == true);
-database_access_cpm = from(DatabaseAccess.*).cpm();
-database_access_percentile = from(DatabaseAccess.latency).percentile(10);
-
-cache_read_resp_time = from(CacheAccess.latency).filter(operation == 
VirtualCacheOperation.Read).longAvg();
-cache_read_sla = from(CacheAccess.*).filter(operation == 
VirtualCacheOperation.Read).percent(status == true);
-cache_read_cpm = from(CacheAccess.*).filter(operation == 
VirtualCacheOperation.Read).cpm();
-cache_read_percentile = from(CacheAccess.latency).filter(operation == 
VirtualCacheOperation.Read).percentile(10);
-
-cache_write_resp_time = from(CacheAccess.latency).filter(operation == 
VirtualCacheOperation.Write).longAvg();
-cache_write_sla = from(CacheAccess.*).filter(operation == 
VirtualCacheOperation.Write).percent(status == true);
-cache_write_cpm = from(CacheAccess.*).filter(operation == 
VirtualCacheOperation.Write).cpm();
-cache_write_percentile = from(CacheAccess.latency).filter(operation == 
VirtualCacheOperation.Write).percentile(10);
-
-cache_access_resp_time = from(CacheAccess.latency).longAvg();
-cache_access_sla = from(CacheAccess.*).percent(status == true);
-cache_access_cpm = from(CacheAccess.*).cpm();
-cache_access_percentile = from(CacheAccess.latency).percentile(10);
\ No newline at end of file
+mq_transmission_latency = 
from(MessageQueueAccess.transmissionLatency).filter(operation == 
MessageQueueOperation.Consume).labeledLongAvg([topic,queue,queue,"1"]);

Review Comment:
   The  demo  labeled avg  metrics 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to