wu-sheng commented on code in PR #9813:
URL: https://github.com/apache/skywalking/pull/9813#discussion_r999094905
##########
oap-server/oal-rt/src/main/java/org/apache/skywalking/oal/rt/parser/AggregationFuncStmt.java:
##########
@@ -49,22 +50,23 @@ public ConditionExpression getNextFuncConditionExpression()
{
return funcConditionExpressions.get(funcConditionExpressionGetIdx++);
}
- public void addFuncArg(Argument argument) {
+ public void addFuncArg(Argument... argument) {
Review Comment:
An argument is an Argument Array. I think this is wrong from grammar level.
We should discuss how to host an Array inside the `Argument`, or create a
sub-type of `Argument`, or create an interface with two implementations??
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
