pg-yang commented on code in PR #9813:
URL: https://github.com/apache/skywalking/pull/9813#discussion_r999111582


##########
oap-server/oal-rt/src/main/java/org/apache/skywalking/oal/rt/parser/AggregationFuncStmt.java:
##########
@@ -49,22 +50,23 @@ public ConditionExpression getNextFuncConditionExpression() 
{
         return funcConditionExpressions.get(funcConditionExpressionGetIdx++);
     }
 
-    public void addFuncArg(Argument argument) {
+    public void addFuncArg(Argument... argument) {

Review Comment:
   Yes ,  Do you  agree  with adding `arrayFuncParamExpression `  to `grammar` ?
   The  demo  such as 
   ```
   mq_transmission_latency = 
from(MessageQueueAccess.transmissionLatency).filter(operation == 
MessageQueueOperation.Consume).labeledLongAvg([topic,queue,queue,"1"]);
   
   ```
   Let's  talk  all here  . 
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to