wu-sheng commented on PR #9828: URL: https://github.com/apache/skywalking/pull/9828#issuecomment-1286859042
> OK, I get the point. Changing the config field to `protected` should also do the trick but that's not strictly enforced for new codes. The idea in this PR sounds good to me now. Yes, that works. But this can't be forced when we implement a new module and forget in the review process. So, I changed a lot to make we don't care `protected` or not. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
