kezhenxu94 commented on code in PR #9828:
URL: https://github.com/apache/skywalking/pull/9828#discussion_r1002322750
##########
oap-server/server-library/library-module/src/main/java/org/apache/skywalking/oap/server/library/module/ModuleProvider.java:
##########
@@ -52,9 +52,28 @@ protected final ModuleManager getManager() {
public abstract Class<? extends ModuleDefine> module();
/**
- *
+ * Create a config creator to initialize this configuration of this module
provider
+ * @return creator instance to initialize the configuration with callback.
Or return null if no config is required.
*/
- public abstract ModuleConfig createConfigBeanIfAbsent();
+ public abstract ConfigCreator newConfigCreator();
Review Comment:
There are tons of warnings (all implementations) because of the raw types,
maybe add the generic type to eliminate them?
```suggestion
public abstract ConfigCreator<? extends ModuleConfig> newConfigCreator();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
