wu-sheng commented on code in PR #10083:
URL: https://github.com/apache/skywalking/pull/10083#discussion_r1038758787
##########
oap-server/server-starter/src/main/java/org/apache/skywalking/oap/server/starter/OAPServerBootstrap.java:
##########
@@ -43,12 +42,10 @@ public static void start() {
ApplicationConfiguration applicationConfiguration =
configLoader.load();
manager.init(applicationConfiguration);
- manager.find(TelemetryModule.NAME)
+ manager.find(CoreModule.NAME)
.provider()
- .getService(MetricsCreator.class)
- .createGauge("uptime", "oap server start up time",
MetricsTag.EMPTY_KEY, MetricsTag.EMPTY_VALUE)
- // Set uptime to second
- .setValue(System.currentTimeMillis() / 1000d);
+ .getService(ServerStatusService.class)
+ .bootedNow(System.currentTimeMillis());
Review Comment:
It is. I did this because, in
https://github.com/apache/skywalking/issues/10051, you would see the booting
uptime matter. So I moved this setup into the core as a unique mechanism.
I don't intend to replace the existing checker.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
