wu-sheng commented on PR #10083: URL: https://github.com/apache/skywalking/pull/10083#issuecomment-1336150668
> I don't mean that. Let's say in another way, if you insist we should add the new service in core module, I hope finally we can rewrite the telemetry module to reuse the server status logics in core module, that should make sense right? I am afraid I can from tech perspective. The Telemetry is the leaf of the module dependencies. That is why I am adding a layer in the core as a delegation. https://github.com/apache/skywalking/blob/18008aa6b24ada6602d9c73e1a9d19b6105d8b59/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/CoreModuleProvider.java#L401-L407 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
