mufiye commented on issue #9999: URL: https://github.com/apache/skywalking/issues/9999#issuecomment-1372204509
Hello @wu-sheng, I'm interested in this issue and have read the documents and codes about this issue in detail. I have some rough ideas about the design of API and also some problems: 1. For the span creating, I would like to use the annotation @LocalSpan, @EntrySpan, @ExitSpan like the @trace in apm-toolkit-trace. 2. For the inject/extract for RPC tracing, I think they respectively correspond to the @ExitSpan and @EntrySpan, but I have no idea about how to pass the contextCarrier. 3. For the capture/continued function, I think the api in apm-toolkit-trace is wonderful, maybe we can just use the similar way? Or I think the exposure of capture() and continued() which can be used before and after entering the thread may be another way. 4. For tag and log for the current span, I would like to use the same functions' design log() and tag() in abstractTracingSpan, of course, the activation is as the link. 5. For Async prepare/finish, I think the functions' design of prepareForAsync() and asyncFinish() in AbstractTracingSpan can be used, but I have no idea about how to guarantee that these two operations correspond to one span? I hope this will be my good first issue in apache-skywalking community. And it would be nice if you could offer some suggestions on my ideas. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
