mufiye commented on issue #9999: URL: https://github.com/apache/skywalking/issues/9999#issuecomment-1373566114
Thanks for your suggestions. * For the `tag` and `log` APIs, I think the APIs in `ActiveSpan` are enough. But maybe we can add the new APIs more like the APIs in kernel `ContextManager`? And in the use case you proposed, the requirements of tag and log are right there. So don't these requirements have to be implemented as our own Tracing APIs? * To implement the Async prepare/finish for span crossing threads, we should build a class corresponding to the span. Adding the `prepareForAsync()` and `asyncFinish()` to `ActiveSpan` is also feasible. But I want to separate it from the `ActiveSpan` class. WDYT? And I think the `Tracer` is more excellent than `TracerManager`, so I will use it. I also want to add new APIs into toolkit-trace lib with new activation to keep compatibility with old APIs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
