dmsolr commented on a change in pull request #3273: Support Zookeeper ACL URL: https://github.com/apache/skywalking/pull/3273#discussion_r314213045
########## File path: oap-server/server-cluster-plugin/cluster-zookeeper-plugin/src/main/java/org/apache/skywalking/oap/server/cluster/plugin/zookeeper/ClusterModuleZookeeperProvider.java ########## @@ -61,7 +79,39 @@ public ClusterModuleZookeeperProvider() { @Override public void prepare() throws ServiceNotProvidedException, ModuleStartException { RetryPolicy retryPolicy = new ExponentialBackoffRetry(config.getBaseSleepTimeMs(), config.getMaxRetries()); - client = CuratorFrameworkFactory.newClient(config.getHostPort(), retryPolicy); + + CuratorFrameworkFactory.Builder builder = CuratorFrameworkFactory.builder() + .retryPolicy(retryPolicy) + .connectString(config.getHostPort()); + if (config.isEnableACL()) { + final List<ACL> acls = Lists.newArrayList(); + + String authInfo = config.getAuth(); + if ("digest".equals(config.getSchema())) { Review comment: When used in the ACL the expression will be the username:base64 encoded SHA1 password digest. But when used in auth the expression must not encode. The other schemas, such as `IP`, it doesn't have this problem. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services