wu-sheng commented on code in PR #128:
URL:
https://github.com/apache/skywalking-satellite/pull/128#discussion_r1137918463
##########
plugins/forwarder/kafka/nativelog/forwarder.go:
##########
@@ -80,10 +82,16 @@ func (f *Forwarder) Forward(batch event.BatchEvents) error {
if !ok {
continue
}
- for _, l := range data.LogList.Logs {
+ for _, logData := range data.LogList.Logs {
+ logdata := &v3.LogData{}
+ err := proto.Unmarshal(logData, logdata)
Review Comment:
Then, we need to make Kafka follow the same way. If the gRPC forwards to the
same channel, the Kafka forward should to the same partition.
@mrproliu Let's make sure this Kafka forward is always consistent with gRPC
routing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
