wu-sheng commented on code in PR #128: URL: https://github.com/apache/skywalking-satellite/pull/128#discussion_r1139630647
########## plugins/forwarder/kafka/nativetracing/forwarder.go: ########## @@ -0,0 +1,121 @@ +// Licensed to Apache Software Foundation (ASF) under one or more contributor +// license agreements. See the NOTICE file distributed with +// this work for additional information regarding copyright +// ownership. Apache Software Foundation (ASF) licenses this file to you under +// the Apache License, Version 2.0 (the "License"); you may +// not use this file except in compliance with the License. +// You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package nativetracing + +import ( + "fmt" + "reflect" + v3 "skywalking.apache.org/repo/goapi/collect/language/agent/v3" + + "github.com/Shopify/sarama" + "github.com/apache/skywalking-satellite/internal/pkg/config" + "github.com/apache/skywalking-satellite/internal/satellite/event" + "google.golang.org/protobuf/proto" + + v1 "skywalking.apache.org/repo/goapi/satellite/data/v1" +) + +const ( + Name = "native-tracing-kafka-forwarder" + ShowName = "Native Tracing Kafka Forwarder" +) + +type Forwarder struct { + config.CommonFields + Topic string `mapstructure:"topic"` // The forwarder topic. + producer sarama.SyncProducer +} + +func (f *Forwarder) Name() string { + return Name +} + +func (f *Forwarder) ShowName() string { + return ShowName +} + +func (f *Forwarder) Description() string { + return "This is a synchronization Kafka forwarder with the SkyWalking native log protocol." +} + +func (f *Forwarder) DefaultConfig() string { + return ` +# The remote topic. +topic: "skywalking-segments" +` +} + +func (f *Forwarder) Prepare(connection interface{}) error { + client, ok := connection.(sarama.Client) + if !ok { + return fmt.Errorf("the %s only accepts a grpc client, but received a %s", + f.Name(), reflect.TypeOf(connection).String()) + } + producer, err := sarama.NewSyncProducerFromClient(client) + if err != nil { + return err + } + f.producer = producer + return nil +} + +func (f *Forwarder) Forward(batch event.BatchEvents) error { + var message []*sarama.ProducerMessage + for _, e := range batch { + switch data := e.GetData().(type) { + case *v1.SniffData_Segment: + segmentObject := &v3.SegmentObject{} + err := proto.Unmarshal(data.Segment, segmentObject) + if err != nil { + return err + } + + message = append(message, &sarama.ProducerMessage{ + Topic: f.Topic, + Key: sarama.StringEncoder(segmentObject.GetTraceSegmentId()), + Value: sarama.ByteEncoder(data.Segment), + }) + case *v1.SniffData_SpanAttachedEvent: + message = append(message, &sarama.ProducerMessage{ Review Comment: All protocols are only getting accepted if the backend supports it. Be clear about the status, and be patient in reading projects and docs. You are proposing a big change. From a maintainer perspective, it is already not easy to follow your first contribution as huge, you should get familiar with the project more rather than keeping saying `best approach` or `should`. Again and again, we have given you the e2e to simulate how to use ebpf agent and all these protocols. You at least should follow them and try them. What you replied makes me concerned you are only pushing this in hurry, rather than really want to understand what is the case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
