lujiajing1126 commented on code in PR #10448:
URL: https://github.com/apache/skywalking/pull/10448#discussion_r1167728084
##########
oap-server/server-storage-plugin/storage-banyandb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/banyandb/BanyanDBAggregationQueryDAO.java:
##########
@@ -85,24 +59,41 @@ protected void apply(MeasureQuery query) {
throw new IOException("field spec is not registered");
}
+ if (schema.getTopNSpec() == null) {
+ throw new IOException("TopN spec is registered");
+ }
+
+ TopNQueryResponse resp = null;
+ if (condition.getOrder() == Order.DES) {
+ resp = topN(schema, timestampRange, condition.getTopN(),
additionalConditions);
+ } else {
+ resp = bottomN(schema, timestampRange, condition.getTopN(),
additionalConditions);
+ }
+
+ if (resp.size() == 0) {
+ return Collections.emptyList();
+ } else if (resp.size() > 1) { // since we have done aggregation, i.e.
MEAN
+ throw new IOException("invalid TopN response");
+ }
+
final List<SelectedRecord> topNList = new ArrayList<>();
- for (DataPoint dataPoint : resp.getDataPoints()) {
+ for (TopNQueryResponse.Item item :
resp.getTopNLists().get(0).getItems()) {
Review Comment:
Answered here
https://github.com/apache/skywalking/pull/10448#discussion_r1118953797
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
