wu-sheng commented on code in PR #10448:
URL: https://github.com/apache/skywalking/pull/10448#discussion_r1172667845
##########
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/storage/annotation/BanyanDB.java:
##########
@@ -157,10 +161,26 @@ enum IndexType {
/**
* StoreIDTag indicates a metric store its ID as a tag for searching.
+ *
* @since 9.4.0
*/
@Target({ElementType.TYPE})
@Retention(RetentionPolicy.RUNTIME)
@interface StoreIDAsTag {
}
+
+ /**
+ * Generate a TopN Aggregation and use the annotated column as a groupBy
tag.
+ * It also contains parameters for TopNAggregation
+ *
+ * @since 9.4.0
+ */
+ @Target({ElementType.FIELD})
+ @Retention(RetentionPolicy.RUNTIME)
+ @Inherited
+ @interface TopNAggregation {
+ int lruSize() default 2;
Review Comment:
```suggestion
/**
* The size of LRU determines the max tolerant time range.
* The data in [T - lruSize * n, T] would be accepted in the
pre-aggregation process.
* T = the current time in the current dimensionality.
* n = interval in the current dimensionality.
*/
int lruSize() default 2;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
