wu-sheng commented on code in PR #561:
URL: https://github.com/apache/skywalking-java/pull/561#discussion_r1239796725
##########
apm-sniffer/apm-agent/src/main/java/org/apache/skywalking/apm/agent/SkyWalkingAgent.java:
##########
@@ -147,6 +146,23 @@ public static void premain(String agentArgs,
Instrumentation instrumentation) th
.addShutdownHook(new Thread(ServiceManager.INSTANCE::shutdown,
"skywalking service shutdown thread"));
}
+ private static AgentBuilder newAgentBuilder(Instrumentation
instrumentation, String nameTrait) {
Review Comment:
```suggestion
/**
* Create a new agent builder through customized {@link ByteBuddy}
powered by
* {@link SWAuxiliaryTypeNamingStrategy} {@link DelegateNamingResolver}
{@link SWMethodNameTransformer} and {@link SWImplementationContextFactory}
*/
private static AgentBuilder newAgentBuilder() {
```
You actually don't need all these parameters and recommend adding comments
like this to indicate the changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
