wu-sheng commented on code in PR #561: URL: https://github.com/apache/skywalking-java/pull/561#discussion_r1239903528
########## apm-sniffer/bytebuddy-patch/src/test/java/org/apache/skywalking/apm/agent/bytebuddy/ConstructorAdvice.java: ########## @@ -0,0 +1,33 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + * + */ + +package org.apache.skywalking.apm.agent.bytebuddy; + +import net.bytebuddy.asm.Advice; + +import java.lang.reflect.Constructor; +import java.util.Arrays; + +public class ConstructorAdvice { + + @Advice.OnMethodExit(inline = false) + public static void onExit(@Advice.Origin Constructor constructor, + @Advice.AllArguments Object[] args) throws Exception { + Log.info(String.format("ConstructorAdvice: constructor: %s, args: %s", constructor, Arrays.asList(args))); + } +} Review Comment: This advice doesn't only log out. It is only used in `AbstractInterceptTest`. How is this verified? This looks like a local debug rather than a UT. If this is in a UT, you should verify this log is logged out. But test like `Intercept2Test`, nothing like this happens. Could you confirm the case? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
