wu-sheng commented on PR #561: URL: https://github.com/apache/skywalking-java/pull/561#issuecomment-1605276928
> > You could override without parent class, and in each using place, you have specific type, you could call hashcode directly. > > Implementing hashCode by subclasses is prone to omissions, low reliability, and can produce a lot of errors in the future. > > 1. Change the method name (for example, computeHashCode) to distinguish it from the default JDK method. > 2. Extract computeHashCode to the tool class > Which way do you prefer? I asked for `DelegateNamingResolver` having multiple `resolve` overloads for all interceptor point type, rather than a new `InterceptPoint` interface. The key point is, `InterceptPoint` doesn't include anything really about `intercepting`. `computeHashCode` is fine to be kept as what it is. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
