wu-sheng commented on code in PR #561: URL: https://github.com/apache/skywalking-java/pull/561#discussion_r1240584395
########## test/plugin/scenarios/retransform-class-tomcat-scenario/configuration.yml: ########## @@ -17,7 +17,5 @@ type: tomcat entryService: http://localhost:8080/retransform-class-tomcat-scenario/case/retransform-class healthCheck: http://localhost:8080/retransform-class-tomcat-scenario/case/healthCheck -environment: - - CATALINA_OPTS="-Dskywalking.agent.is_cache_enhanced_class=true -Dskywalking.agent.class_cache_mode=FILE" dependencies: -withPlugins: apm-spring-annotation-plugin-*.jar +withPlugins: apm-*.jar Review Comment: I don't think general plugins matters. After all, the worst case, some plugins would work in retransfer case, right? We could pick some for tests. 1. General Spring with another agents. 2. Tomcat(another class loader mode) with another agent 3. SkyWalking before or after another agents. 4. SkyWalking before or after bytebuddy based agent(a test agent maybe?) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
