Yangfisher1 commented on code in PR #127: URL: https://github.com/apache/skywalking-kubernetes/pull/127#discussion_r1272914882
########## chart/skywalking/templates/oap-deployment.yaml: ########## @@ -122,6 +122,17 @@ spec: - containerPort: {{ $value }} name: {{ $key }} {{- end }} + +{{- if eq .Values.oap.env.SW_RECEIVER_ZIPKIN "default" }} + - containerPort: 9411 + name: "zipkin" +{{- end }} + +{{- if eq .Values.oap.env.SW_QUERY_ZIPKIN "default" }} + - containerPort: 9412 + name: "zipkin-ui" Review Comment: @wu-sheng I think it's the original [Zipkin](https://skywalking.apache.org/docs/main/next/en/setup/backend/zipkin-trace/) bounded in Skywalking OAP Server. We just configure the deployment, making it easier to use Zipkin trace in Skywalking on k8s cluster since I find there're some issues about the configuration of Zipkin. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org