kezhenxu94 commented on PR #127:
URL:
https://github.com/apache/skywalking-kubernetes/pull/127#issuecomment-1649213683
> values.yaml
>
> ```
> oap:
> ports:
> # add more ports here if you need, for example
> # zabbix: 10051
> grpc: 11800
> rest: 12800
> # zipkinReceiver: 9411
> # zipkinQuery: 9412
> ```
>
> oap-deployment.yaml
>
> ```
> env:
> {{- if .Values.oap.ports.zipkinReceiver }}
> - name: SW_RECEIVER_ZIPKIN
> value: "default"
> {{- end }}
> {{- if .Values.oap.ports.zipkinQuery }}
> - name: SW_QUERY_ZIPKIN
> value: "default"
> {{- end }}
> ```
>
> ui-deployment.yaml
>
> ```
> env:
> {{- if .Values.oap.ports.zipkinQuery }}
> - name: SW_ZIPKIN_ADDRESS
> value: "http://{{ template "skywalking.oap.fullname" . }}:{{
.Values.oap.ports.zipkinQuery }}"
> {{- end }}
> ```
>
> I think it might be more convenient. What do you think? @kezhenxu94
@Yangfisher1
This works for me too, another good point is that we can also set
`SW_QUERY_ZIPKIN_REST_PORT` to `.Values.ports.zipkinQuery`, @Yangfisher1 in
that case users can set Zipin port to arbitrary port, I think
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
