wankai123 commented on code in PR #11336:
URL: https://github.com/apache/skywalking/pull/11336#discussion_r1327392067
##########
oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/RunningRule.java:
##########
@@ -199,6 +199,7 @@ public void moveTo(LocalDateTime targetTime) {
public List<AlarmMessage> check() {
List<AlarmMessage> alarmMessageList = new ArrayList<>(30);
+ clearWindowsOutOfDate();
windows.forEach((alarmEntity, window) -> {
Review Comment:
the previous check and return is OK, we don't need to loop twice.
```java
if (window.checkOutOfDate()) {
alarmEntityList.add(alarmEntity);
return;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
