wu-sheng commented on code in PR #11336:
URL: https://github.com/apache/skywalking/pull/11336#discussion_r1327396083
##########
oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/RunningRule.java:
##########
@@ -383,6 +396,17 @@ private boolean isMatch() {
return isMatch == 1;
}
+ public boolean checkOutOfDate() {
Review Comment:
```suggestion
public boolean isExpired() {
```
Please use `expired` to replace `out-of-date`. Because `out-of-date` is more
about idea, such as old docs and design.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
