hanahmily commented on code in PR #361: URL: https://github.com/apache/skywalking-banyandb/pull/361#discussion_r1436164084
########## banyand/stream/elements.go: ########## @@ -0,0 +1,153 @@ +// Licensed to Apache Software Foundation (ASF) under one or more contributor +// license agreements. See the NOTICE file distributed with +// this work for additional information regarding copyright +// ownership. Apache Software Foundation (ASF) licenses this file to you under +// the Apache License, Version 2.0 (the "License"); you may +// not use this file except in compliance with the License. +// You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package stream + +import ( + "bytes" + + "github.com/pkg/errors" + + "github.com/apache/skywalking-banyandb/api/common" + "github.com/apache/skywalking-banyandb/banyand/internal/storage" + "github.com/apache/skywalking-banyandb/pkg/index" + pbv1 "github.com/apache/skywalking-banyandb/pkg/pb/v1" + "github.com/apache/skywalking-banyandb/pkg/timestamp" +) + +type nameValue struct { + name string + value []byte + valueArr [][]byte + valueType pbv1.ValueType +} + +func (n *nameValue) size() int { + s := len(n.name) + if n.value != nil { + s += len(n.value) + } + if n.valueArr != nil { + for i := range n.valueArr { + s += len(n.valueArr[i]) + } + } + return s +} + +func (n *nameValue) marshal() []byte { + if n.valueArr != nil { + var dst []byte + for i := range n.valueArr { + if n.valueType == pbv1.ValueTypeInt64Arr { + dst = append(dst, n.valueArr[i]...) + continue + } + dst = marshalVarArray(dst, n.valueArr[i]) + } + return dst + } + return n.value +} + +const ( + entityDelimiter = '|' + escape = '\\' +) + +func marshalVarArray(dest, src []byte) []byte { + if bytes.IndexByte(src, entityDelimiter) < 0 && bytes.IndexByte(src, escape) < 0 { + dest = append(dest, src...) + dest = append(dest, entityDelimiter) + return dest + } + for _, b := range src { + if b == entityDelimiter || b == escape { + dest = append(dest, escape) + } + dest = append(dest, b) + } + dest = append(dest, entityDelimiter) + return dest +} + +func unmarshalVarArray(dest, src []byte) ([]byte, []byte, error) { + if len(src) == 0 { + return nil, nil, errors.New("empty entity value") + } + if src[0] == entityDelimiter { + return dest, src[1:], nil + } + for len(src) > 0 { + if src[0] == escape { + if len(src) < 2 { + return nil, nil, errors.New("invalid escape character") + } + src = src[1:] + dest = append(dest, src[0]) + } else if src[0] == entityDelimiter { + return dest, src[1:], nil + } else { + dest = append(dest, src[0]) + } + src = src[1:] + } + return nil, nil, errors.New("invalid variable array") +} + +type nameValues struct { + name string + values []*nameValue +} + +type dataPoints struct { Review Comment: ```suggestion type elements struct { ``` ########## banyand/stream/elements.go: ########## @@ -0,0 +1,153 @@ +// Licensed to Apache Software Foundation (ASF) under one or more contributor +// license agreements. See the NOTICE file distributed with +// this work for additional information regarding copyright +// ownership. Apache Software Foundation (ASF) licenses this file to you under +// the Apache License, Version 2.0 (the "License"); you may +// not use this file except in compliance with the License. +// You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package stream + +import ( + "bytes" + + "github.com/pkg/errors" + + "github.com/apache/skywalking-banyandb/api/common" + "github.com/apache/skywalking-banyandb/banyand/internal/storage" + "github.com/apache/skywalking-banyandb/pkg/index" + pbv1 "github.com/apache/skywalking-banyandb/pkg/pb/v1" + "github.com/apache/skywalking-banyandb/pkg/timestamp" +) + +type nameValue struct { + name string + value []byte + valueArr [][]byte + valueType pbv1.ValueType +} + +func (n *nameValue) size() int { + s := len(n.name) + if n.value != nil { + s += len(n.value) + } + if n.valueArr != nil { + for i := range n.valueArr { + s += len(n.valueArr[i]) + } + } + return s +} + +func (n *nameValue) marshal() []byte { + if n.valueArr != nil { + var dst []byte + for i := range n.valueArr { + if n.valueType == pbv1.ValueTypeInt64Arr { + dst = append(dst, n.valueArr[i]...) + continue + } + dst = marshalVarArray(dst, n.valueArr[i]) + } + return dst + } + return n.value +} + +const ( + entityDelimiter = '|' + escape = '\\' +) + +func marshalVarArray(dest, src []byte) []byte { + if bytes.IndexByte(src, entityDelimiter) < 0 && bytes.IndexByte(src, escape) < 0 { + dest = append(dest, src...) + dest = append(dest, entityDelimiter) + return dest + } + for _, b := range src { + if b == entityDelimiter || b == escape { + dest = append(dest, escape) + } + dest = append(dest, b) + } + dest = append(dest, entityDelimiter) + return dest +} + +func unmarshalVarArray(dest, src []byte) ([]byte, []byte, error) { + if len(src) == 0 { + return nil, nil, errors.New("empty entity value") + } + if src[0] == entityDelimiter { + return dest, src[1:], nil + } + for len(src) > 0 { + if src[0] == escape { + if len(src) < 2 { + return nil, nil, errors.New("invalid escape character") + } + src = src[1:] + dest = append(dest, src[0]) + } else if src[0] == entityDelimiter { + return dest, src[1:], nil + } else { + dest = append(dest, src[0]) + } + src = src[1:] + } + return nil, nil, errors.New("invalid variable array") +} + +type nameValues struct { Review Comment: ```suggestion type tagValues struct { ``` ########## banyand/stream/elements.go: ########## @@ -0,0 +1,153 @@ +// Licensed to Apache Software Foundation (ASF) under one or more contributor +// license agreements. See the NOTICE file distributed with +// this work for additional information regarding copyright +// ownership. Apache Software Foundation (ASF) licenses this file to you under +// the Apache License, Version 2.0 (the "License"); you may +// not use this file except in compliance with the License. +// You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package stream + +import ( + "bytes" + + "github.com/pkg/errors" + + "github.com/apache/skywalking-banyandb/api/common" + "github.com/apache/skywalking-banyandb/banyand/internal/storage" + "github.com/apache/skywalking-banyandb/pkg/index" + pbv1 "github.com/apache/skywalking-banyandb/pkg/pb/v1" + "github.com/apache/skywalking-banyandb/pkg/timestamp" +) + +type nameValue struct { Review Comment: ```suggestion type tagValue struct { ``` ########## banyand/stream/elements.go: ########## @@ -0,0 +1,153 @@ +// Licensed to Apache Software Foundation (ASF) under one or more contributor +// license agreements. See the NOTICE file distributed with +// this work for additional information regarding copyright +// ownership. Apache Software Foundation (ASF) licenses this file to you under +// the Apache License, Version 2.0 (the "License"); you may +// not use this file except in compliance with the License. +// You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package stream + +import ( + "bytes" + + "github.com/pkg/errors" + + "github.com/apache/skywalking-banyandb/api/common" + "github.com/apache/skywalking-banyandb/banyand/internal/storage" + "github.com/apache/skywalking-banyandb/pkg/index" + pbv1 "github.com/apache/skywalking-banyandb/pkg/pb/v1" + "github.com/apache/skywalking-banyandb/pkg/timestamp" +) + +type nameValue struct { + name string + value []byte + valueArr [][]byte + valueType pbv1.ValueType +} + +func (n *nameValue) size() int { + s := len(n.name) + if n.value != nil { + s += len(n.value) + } + if n.valueArr != nil { + for i := range n.valueArr { + s += len(n.valueArr[i]) + } + } + return s +} + +func (n *nameValue) marshal() []byte { + if n.valueArr != nil { + var dst []byte + for i := range n.valueArr { + if n.valueType == pbv1.ValueTypeInt64Arr { + dst = append(dst, n.valueArr[i]...) + continue + } + dst = marshalVarArray(dst, n.valueArr[i]) + } + return dst + } + return n.value +} + +const ( + entityDelimiter = '|' + escape = '\\' +) + +func marshalVarArray(dest, src []byte) []byte { + if bytes.IndexByte(src, entityDelimiter) < 0 && bytes.IndexByte(src, escape) < 0 { + dest = append(dest, src...) + dest = append(dest, entityDelimiter) + return dest + } + for _, b := range src { + if b == entityDelimiter || b == escape { + dest = append(dest, escape) + } + dest = append(dest, b) + } + dest = append(dest, entityDelimiter) + return dest +} + +func unmarshalVarArray(dest, src []byte) ([]byte, []byte, error) { + if len(src) == 0 { + return nil, nil, errors.New("empty entity value") + } + if src[0] == entityDelimiter { + return dest, src[1:], nil + } + for len(src) > 0 { + if src[0] == escape { + if len(src) < 2 { + return nil, nil, errors.New("invalid escape character") + } + src = src[1:] + dest = append(dest, src[0]) + } else if src[0] == entityDelimiter { + return dest, src[1:], nil + } else { + dest = append(dest, src[0]) + } + src = src[1:] + } + return nil, nil, errors.New("invalid variable array") +} + +type nameValues struct { + name string + values []*nameValue +} + +type dataPoints struct { + seriesIDs []common.SeriesID + timestamps []int64 + elementIDs []string + tagFamilies [][]nameValues +} + +func (d *dataPoints) Len() int { + return len(d.seriesIDs) +} + +func (d *dataPoints) Less(i, j int) bool { + if d.seriesIDs[i] != d.seriesIDs[j] { + return d.seriesIDs[i] < d.seriesIDs[j] + } + return d.timestamps[i] < d.timestamps[j] +} + +func (d *dataPoints) Swap(i, j int) { + d.seriesIDs[i], d.seriesIDs[j] = d.seriesIDs[j], d.seriesIDs[i] + d.timestamps[i], d.timestamps[j] = d.timestamps[j], d.timestamps[i] + d.tagFamilies[i], d.tagFamilies[j] = d.tagFamilies[j], d.tagFamilies[i] +} + +type dataPointsInTable struct { Review Comment: ```suggestion type elementsInTable struct { ``` ########## banyand/stream/elements.go: ########## @@ -0,0 +1,153 @@ +// Licensed to Apache Software Foundation (ASF) under one or more contributor +// license agreements. See the NOTICE file distributed with +// this work for additional information regarding copyright +// ownership. Apache Software Foundation (ASF) licenses this file to you under +// the Apache License, Version 2.0 (the "License"); you may +// not use this file except in compliance with the License. +// You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package stream + +import ( + "bytes" + + "github.com/pkg/errors" + + "github.com/apache/skywalking-banyandb/api/common" + "github.com/apache/skywalking-banyandb/banyand/internal/storage" + "github.com/apache/skywalking-banyandb/pkg/index" + pbv1 "github.com/apache/skywalking-banyandb/pkg/pb/v1" + "github.com/apache/skywalking-banyandb/pkg/timestamp" +) + +type nameValue struct { + name string + value []byte + valueArr [][]byte + valueType pbv1.ValueType +} + +func (n *nameValue) size() int { + s := len(n.name) + if n.value != nil { + s += len(n.value) + } + if n.valueArr != nil { + for i := range n.valueArr { + s += len(n.valueArr[i]) + } + } + return s +} + +func (n *nameValue) marshal() []byte { + if n.valueArr != nil { + var dst []byte + for i := range n.valueArr { + if n.valueType == pbv1.ValueTypeInt64Arr { + dst = append(dst, n.valueArr[i]...) + continue + } + dst = marshalVarArray(dst, n.valueArr[i]) + } + return dst + } + return n.value +} + +const ( + entityDelimiter = '|' + escape = '\\' +) + +func marshalVarArray(dest, src []byte) []byte { + if bytes.IndexByte(src, entityDelimiter) < 0 && bytes.IndexByte(src, escape) < 0 { + dest = append(dest, src...) + dest = append(dest, entityDelimiter) + return dest + } + for _, b := range src { + if b == entityDelimiter || b == escape { + dest = append(dest, escape) + } + dest = append(dest, b) + } + dest = append(dest, entityDelimiter) + return dest +} + +func unmarshalVarArray(dest, src []byte) ([]byte, []byte, error) { + if len(src) == 0 { + return nil, nil, errors.New("empty entity value") + } + if src[0] == entityDelimiter { + return dest, src[1:], nil + } + for len(src) > 0 { + if src[0] == escape { + if len(src) < 2 { + return nil, nil, errors.New("invalid escape character") + } + src = src[1:] + dest = append(dest, src[0]) + } else if src[0] == entityDelimiter { + return dest, src[1:], nil + } else { + dest = append(dest, src[0]) + } + src = src[1:] + } + return nil, nil, errors.New("invalid variable array") +} + +type nameValues struct { + name string + values []*nameValue +} + +type dataPoints struct { + seriesIDs []common.SeriesID + timestamps []int64 + elementIDs []string + tagFamilies [][]nameValues +} + +func (d *dataPoints) Len() int { + return len(d.seriesIDs) +} + +func (d *dataPoints) Less(i, j int) bool { + if d.seriesIDs[i] != d.seriesIDs[j] { + return d.seriesIDs[i] < d.seriesIDs[j] + } + return d.timestamps[i] < d.timestamps[j] +} + +func (d *dataPoints) Swap(i, j int) { + d.seriesIDs[i], d.seriesIDs[j] = d.seriesIDs[j], d.seriesIDs[i] + d.timestamps[i], d.timestamps[j] = d.timestamps[j], d.timestamps[i] + d.tagFamilies[i], d.tagFamilies[j] = d.tagFamilies[j], d.tagFamilies[i] +} + +type dataPointsInTable struct { + timeRange timestamp.TimeRange + tsTable storage.TSTableWrapper[*tsTable] + + dataPoints dataPoints +} + +type dataPointsInGroup struct { Review Comment: ```suggestion type elementsInGroup struct { ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
