hanahmily commented on code in PR #361: URL: https://github.com/apache/skywalking-banyandb/pull/361#discussion_r1436265752
########## banyand/stream/query.go: ########## @@ -0,0 +1,361 @@ +// Licensed to Apache Software Foundation (ASF) under one or more contributor +// license agreements. See the NOTICE file distributed with +// this work for additional information regarding copyright +// ownership. Apache Software Foundation (ASF) licenses this file to you under +// the Apache License, Version 2.0 (the "License"); you may +// not use this file except in compliance with the License. +// You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package stream + +import ( + "container/heap" + + "github.com/apache/skywalking-banyandb/api/common" + modelv1 "github.com/apache/skywalking-banyandb/api/proto/banyandb/model/v1" + "github.com/apache/skywalking-banyandb/pkg/convert" + "github.com/apache/skywalking-banyandb/pkg/logger" + pbv1 "github.com/apache/skywalking-banyandb/pkg/pb/v1" +) + +type queryOptions struct { + pbv1.StreamQueryOptions + minTimestamp int64 + maxTimestamp int64 +} + +func mustDecodeTagValue(valueType pbv1.ValueType, value []byte) *modelv1.TagValue { + if value == nil { + switch valueType { + case pbv1.ValueTypeInt64: + logger.Panicf("int64 can be nil") + case pbv1.ValueTypeStr: + return pbv1.EmptyStrTagValue + case pbv1.ValueTypeStrArr: + return pbv1.EmptyStrArrTagValue + case pbv1.ValueTypeInt64Arr: + return pbv1.EmptyIntArrTagValue + case pbv1.ValueTypeBinaryData: + return pbv1.EmptyBinaryTagValue + default: + return pbv1.NullTagValue + } + } + switch valueType { + case pbv1.ValueTypeInt64: + return int64TagValue(convert.BytesToInt64(value)) + case pbv1.ValueTypeStr: + return strTagValue(string(value)) + case pbv1.ValueTypeBinaryData: + return binaryDataTagValue(value) + case pbv1.ValueTypeInt64Arr: + var values []int64 + for i := 0; i < len(value); i += 8 { + values = append(values, convert.BytesToInt64(value[i:i+8])) + } + return int64ArrTagValue(values) + case pbv1.ValueTypeStrArr: + var values []string + bb := bigValuePool.Generate() + var err error + for len(value) > 0 { + bb.Buf, value, err = unmarshalVarArray(bb.Buf[:0], value) + if err != nil { + logger.Panicf("unmarshalVarArray failed: %v", err) + } + values = append(values, string(bb.Buf)) + } + return strArrTagValue(values) + default: + logger.Panicf("unsupported value type: %v", valueType) + return nil + } +} + +func int64TagValue(value int64) *modelv1.TagValue { + return &modelv1.TagValue{ + Value: &modelv1.TagValue_Int{ + Int: &modelv1.Int{ + Value: value, + }, + }, + } +} + +func strTagValue(value string) *modelv1.TagValue { + return &modelv1.TagValue{ + Value: &modelv1.TagValue_Str{ + Str: &modelv1.Str{ + Value: value, + }, + }, + } +} + +func binaryDataTagValue(value []byte) *modelv1.TagValue { + data := make([]byte, len(value)) + copy(data, value) + return &modelv1.TagValue{ + Value: &modelv1.TagValue_BinaryData{ + BinaryData: data, + }, + } +} + +func int64ArrTagValue(values []int64) *modelv1.TagValue { + return &modelv1.TagValue{ + Value: &modelv1.TagValue_IntArray{ + IntArray: &modelv1.IntArray{ + Value: values, + }, + }, + } +} + +func strArrTagValue(values []string) *modelv1.TagValue { + return &modelv1.TagValue{ + Value: &modelv1.TagValue_StrArray{ + StrArray: &modelv1.StrArray{ + Value: values, + }, + }, + } +} + +// nolint: unused +func mustDecodeFieldValue(valueType pbv1.ValueType, value []byte) *modelv1.FieldValue { + if value == nil { + switch valueType { + case pbv1.ValueTypeInt64, pbv1.ValueTypeFloat64: + logger.Panicf("int64 and float64 can't be nil") + case pbv1.ValueTypeStr: + return pbv1.EmptyStrFieldValue + case pbv1.ValueTypeBinaryData: + return pbv1.EmptyBinaryFieldValue + default: + return pbv1.NullFieldValue + } + } + switch valueType { + case pbv1.ValueTypeInt64: + return int64FieldValue(convert.BytesToInt64(value)) + case pbv1.ValueTypeFloat64: + return float64FieldValue(convert.BytesToFloat64(value)) + case pbv1.ValueTypeStr: + return strFieldValue(string(value)) + case pbv1.ValueTypeBinaryData: + return binaryDataFieldValue(value) + default: + logger.Panicf("unsupported value type: %v", valueType) + return nil + } +} + +// nolint: unused +func int64FieldValue(value int64) *modelv1.FieldValue { + return &modelv1.FieldValue{ + Value: &modelv1.FieldValue_Int{ + Int: &modelv1.Int{ + Value: value, + }, + }, + } +} + +// nolint: unused +func float64FieldValue(value float64) *modelv1.FieldValue { + return &modelv1.FieldValue{ + Value: &modelv1.FieldValue_Float{ + Float: &modelv1.Float{ + Value: value, + }, + }, + } +} + +// nolint: unused +func strFieldValue(value string) *modelv1.FieldValue { + return &modelv1.FieldValue{ + Value: &modelv1.FieldValue_Str{ + Str: &modelv1.Str{ + Value: value, + }, + }, + } +} + +// nolint: unused +func binaryDataFieldValue(value []byte) *modelv1.FieldValue { + data := make([]byte, len(value)) + copy(data, value) + return &modelv1.FieldValue{ + Value: &modelv1.FieldValue_BinaryData{ + BinaryData: data, + }, + } +} + +type queryResult struct { + sidToIndex map[common.SeriesID]int + data []*blockCursor + pws []*partWrapper + loaded bool + orderByTS bool + ascTS bool +} + +func (qr *queryResult) Pull() *pbv1.Result { + if !qr.loaded { + if len(qr.data) == 0 { + return nil + } + // TODO:// Parallel load + tmpBlock := generateBlock() + defer releaseBlock(tmpBlock) + for i := 0; i < len(qr.data); i++ { + if !qr.data[i].loadData(tmpBlock) { + qr.data = append(qr.data[:i], qr.data[i+1:]...) + i-- + } + if qr.orderByTimestampDesc() { + qr.data[i].idx = len(qr.data[i].timestamps) - 1 + } + } + qr.loaded = true + heap.Init(qr) + } + if len(qr.data) == 0 { + return nil + } + if len(qr.data) == 1 { + r := &pbv1.Result{} + bc := qr.data[0] + bc.copyAllTo(r) + qr.data = qr.data[:0] + return r + } + return qr.merge() +} + +func (qr *queryResult) Release() { + for i, v := range qr.data { + releaseBlockCursor(v) + qr.data[i] = nil + } + qr.data = qr.data[:0] + for i := range qr.pws { + qr.pws[i].decRef() + } + qr.pws = qr.pws[:0] +} + +func (qr queryResult) Len() int { + return len(qr.data) +} + +func (qr queryResult) Less(i, j int) bool { + leftTS := qr.data[i].timestamps[qr.data[i].idx] + rightTS := qr.data[j].timestamps[qr.data[j].idx] + leftVersion := qr.data[i].p.partMetadata.Version + rightVersion := qr.data[j].p.partMetadata.Version + if qr.orderByTS { + if leftTS == rightTS { + if qr.data[i].bm.seriesID == qr.data[j].bm.seriesID { + // sort version in descending order if timestamps and seriesID are equal + return leftVersion > rightVersion + } + // sort seriesID in ascending order if timestamps are equal + return qr.data[i].bm.seriesID < qr.data[j].bm.seriesID + } + if qr.ascTS { + return leftTS < rightTS + } + return leftTS > rightTS + } + leftSIDIndex := qr.sidToIndex[qr.data[i].bm.seriesID] + rightSIDIndex := qr.sidToIndex[qr.data[j].bm.seriesID] + if leftSIDIndex == rightSIDIndex { + if leftTS == rightTS { + // sort version in descending order if timestamps and seriesID are equal + return leftVersion > rightVersion + } + // sort timestamps in ascending order if seriesID are equal + return leftTS < rightTS + } + return leftSIDIndex < rightSIDIndex +} + +func (qr queryResult) Swap(i, j int) { + qr.data[i], qr.data[j] = qr.data[j], qr.data[i] +} + +func (qr *queryResult) Push(x interface{}) { + qr.data = append(qr.data, x.(*blockCursor)) +} + +func (qr *queryResult) Pop() interface{} { + old := qr.data + n := len(old) + x := old[n-1] + qr.data = old[0 : n-1] + return x +} + +func (qr *queryResult) orderByTimestampDesc() bool { + return qr.orderByTS && !qr.ascTS +} + +func (qr *queryResult) merge() *pbv1.Result { + step := 1 + if qr.orderByTimestampDesc() { + step = -1 + } + result := &pbv1.Result{} + var lastPartVersion int64 + var lastSid common.SeriesID + + for qr.Len() > 0 { + topBC := qr.data[0] + if lastSid != 0 && topBC.bm.seriesID != lastSid { + return result + } + lastSid = topBC.bm.seriesID + + if len(result.Timestamps) > 0 && + topBC.timestamps[topBC.idx] == result.Timestamps[len(result.Timestamps)-1] { + if topBC.p.partMetadata.Version > lastPartVersion { Review Comment: Please remove the deduplication piece because the stream could store duplicated elements. ########## banyand/stream/query.go: ########## @@ -0,0 +1,361 @@ +// Licensed to Apache Software Foundation (ASF) under one or more contributor +// license agreements. See the NOTICE file distributed with +// this work for additional information regarding copyright +// ownership. Apache Software Foundation (ASF) licenses this file to you under +// the Apache License, Version 2.0 (the "License"); you may +// not use this file except in compliance with the License. +// You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package stream + +import ( + "container/heap" + + "github.com/apache/skywalking-banyandb/api/common" + modelv1 "github.com/apache/skywalking-banyandb/api/proto/banyandb/model/v1" + "github.com/apache/skywalking-banyandb/pkg/convert" + "github.com/apache/skywalking-banyandb/pkg/logger" + pbv1 "github.com/apache/skywalking-banyandb/pkg/pb/v1" +) + +type queryOptions struct { + pbv1.StreamQueryOptions + minTimestamp int64 + maxTimestamp int64 +} + +func mustDecodeTagValue(valueType pbv1.ValueType, value []byte) *modelv1.TagValue { + if value == nil { + switch valueType { + case pbv1.ValueTypeInt64: + logger.Panicf("int64 can be nil") + case pbv1.ValueTypeStr: + return pbv1.EmptyStrTagValue + case pbv1.ValueTypeStrArr: + return pbv1.EmptyStrArrTagValue + case pbv1.ValueTypeInt64Arr: + return pbv1.EmptyIntArrTagValue + case pbv1.ValueTypeBinaryData: + return pbv1.EmptyBinaryTagValue + default: + return pbv1.NullTagValue + } + } + switch valueType { + case pbv1.ValueTypeInt64: + return int64TagValue(convert.BytesToInt64(value)) + case pbv1.ValueTypeStr: + return strTagValue(string(value)) + case pbv1.ValueTypeBinaryData: + return binaryDataTagValue(value) + case pbv1.ValueTypeInt64Arr: + var values []int64 + for i := 0; i < len(value); i += 8 { + values = append(values, convert.BytesToInt64(value[i:i+8])) + } + return int64ArrTagValue(values) + case pbv1.ValueTypeStrArr: + var values []string + bb := bigValuePool.Generate() + var err error + for len(value) > 0 { + bb.Buf, value, err = unmarshalVarArray(bb.Buf[:0], value) + if err != nil { + logger.Panicf("unmarshalVarArray failed: %v", err) + } + values = append(values, string(bb.Buf)) + } + return strArrTagValue(values) + default: + logger.Panicf("unsupported value type: %v", valueType) + return nil + } +} + +func int64TagValue(value int64) *modelv1.TagValue { + return &modelv1.TagValue{ + Value: &modelv1.TagValue_Int{ + Int: &modelv1.Int{ + Value: value, + }, + }, + } +} + +func strTagValue(value string) *modelv1.TagValue { + return &modelv1.TagValue{ + Value: &modelv1.TagValue_Str{ + Str: &modelv1.Str{ + Value: value, + }, + }, + } +} + +func binaryDataTagValue(value []byte) *modelv1.TagValue { + data := make([]byte, len(value)) + copy(data, value) + return &modelv1.TagValue{ + Value: &modelv1.TagValue_BinaryData{ + BinaryData: data, + }, + } +} + +func int64ArrTagValue(values []int64) *modelv1.TagValue { + return &modelv1.TagValue{ + Value: &modelv1.TagValue_IntArray{ + IntArray: &modelv1.IntArray{ + Value: values, + }, + }, + } +} + +func strArrTagValue(values []string) *modelv1.TagValue { + return &modelv1.TagValue{ + Value: &modelv1.TagValue_StrArray{ + StrArray: &modelv1.StrArray{ + Value: values, + }, + }, + } +} + +// nolint: unused +func mustDecodeFieldValue(valueType pbv1.ValueType, value []byte) *modelv1.FieldValue { + if value == nil { + switch valueType { + case pbv1.ValueTypeInt64, pbv1.ValueTypeFloat64: + logger.Panicf("int64 and float64 can't be nil") + case pbv1.ValueTypeStr: + return pbv1.EmptyStrFieldValue + case pbv1.ValueTypeBinaryData: + return pbv1.EmptyBinaryFieldValue + default: + return pbv1.NullFieldValue + } + } + switch valueType { + case pbv1.ValueTypeInt64: + return int64FieldValue(convert.BytesToInt64(value)) + case pbv1.ValueTypeFloat64: + return float64FieldValue(convert.BytesToFloat64(value)) + case pbv1.ValueTypeStr: + return strFieldValue(string(value)) + case pbv1.ValueTypeBinaryData: + return binaryDataFieldValue(value) + default: + logger.Panicf("unsupported value type: %v", valueType) + return nil + } +} + +// nolint: unused +func int64FieldValue(value int64) *modelv1.FieldValue { + return &modelv1.FieldValue{ + Value: &modelv1.FieldValue_Int{ + Int: &modelv1.Int{ + Value: value, + }, + }, + } +} + +// nolint: unused +func float64FieldValue(value float64) *modelv1.FieldValue { + return &modelv1.FieldValue{ + Value: &modelv1.FieldValue_Float{ + Float: &modelv1.Float{ + Value: value, + }, + }, + } +} + +// nolint: unused +func strFieldValue(value string) *modelv1.FieldValue { + return &modelv1.FieldValue{ + Value: &modelv1.FieldValue_Str{ + Str: &modelv1.Str{ + Value: value, + }, + }, + } +} + +// nolint: unused +func binaryDataFieldValue(value []byte) *modelv1.FieldValue { + data := make([]byte, len(value)) + copy(data, value) + return &modelv1.FieldValue{ + Value: &modelv1.FieldValue_BinaryData{ + BinaryData: data, + }, + } +} + +type queryResult struct { + sidToIndex map[common.SeriesID]int + data []*blockCursor + pws []*partWrapper + loaded bool + orderByTS bool + ascTS bool +} + +func (qr *queryResult) Pull() *pbv1.Result { + if !qr.loaded { + if len(qr.data) == 0 { + return nil + } + // TODO:// Parallel load + tmpBlock := generateBlock() + defer releaseBlock(tmpBlock) + for i := 0; i < len(qr.data); i++ { + if !qr.data[i].loadData(tmpBlock) { + qr.data = append(qr.data[:i], qr.data[i+1:]...) + i-- + } + if qr.orderByTimestampDesc() { + qr.data[i].idx = len(qr.data[i].timestamps) - 1 + } + } + qr.loaded = true + heap.Init(qr) + } + if len(qr.data) == 0 { + return nil + } + if len(qr.data) == 1 { + r := &pbv1.Result{} + bc := qr.data[0] + bc.copyAllTo(r) + qr.data = qr.data[:0] + return r + } + return qr.merge() +} + +func (qr *queryResult) Release() { + for i, v := range qr.data { + releaseBlockCursor(v) + qr.data[i] = nil + } + qr.data = qr.data[:0] + for i := range qr.pws { + qr.pws[i].decRef() + } + qr.pws = qr.pws[:0] +} + +func (qr queryResult) Len() int { + return len(qr.data) +} + +func (qr queryResult) Less(i, j int) bool { + leftTS := qr.data[i].timestamps[qr.data[i].idx] + rightTS := qr.data[j].timestamps[qr.data[j].idx] + leftVersion := qr.data[i].p.partMetadata.Version + rightVersion := qr.data[j].p.partMetadata.Version + if qr.orderByTS { + if leftTS == rightTS { Review Comment: Remove the deduplication as well ########## banyand/stream/query.go: ########## @@ -0,0 +1,361 @@ +// Licensed to Apache Software Foundation (ASF) under one or more contributor +// license agreements. See the NOTICE file distributed with +// this work for additional information regarding copyright +// ownership. Apache Software Foundation (ASF) licenses this file to you under +// the Apache License, Version 2.0 (the "License"); you may +// not use this file except in compliance with the License. +// You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package stream + +import ( + "container/heap" + + "github.com/apache/skywalking-banyandb/api/common" + modelv1 "github.com/apache/skywalking-banyandb/api/proto/banyandb/model/v1" + "github.com/apache/skywalking-banyandb/pkg/convert" + "github.com/apache/skywalking-banyandb/pkg/logger" + pbv1 "github.com/apache/skywalking-banyandb/pkg/pb/v1" +) + +type queryOptions struct { + pbv1.StreamQueryOptions + minTimestamp int64 + maxTimestamp int64 +} + +func mustDecodeTagValue(valueType pbv1.ValueType, value []byte) *modelv1.TagValue { + if value == nil { + switch valueType { + case pbv1.ValueTypeInt64: + logger.Panicf("int64 can be nil") + case pbv1.ValueTypeStr: + return pbv1.EmptyStrTagValue + case pbv1.ValueTypeStrArr: + return pbv1.EmptyStrArrTagValue + case pbv1.ValueTypeInt64Arr: + return pbv1.EmptyIntArrTagValue + case pbv1.ValueTypeBinaryData: + return pbv1.EmptyBinaryTagValue + default: + return pbv1.NullTagValue + } + } + switch valueType { + case pbv1.ValueTypeInt64: + return int64TagValue(convert.BytesToInt64(value)) + case pbv1.ValueTypeStr: + return strTagValue(string(value)) + case pbv1.ValueTypeBinaryData: + return binaryDataTagValue(value) + case pbv1.ValueTypeInt64Arr: + var values []int64 + for i := 0; i < len(value); i += 8 { + values = append(values, convert.BytesToInt64(value[i:i+8])) + } + return int64ArrTagValue(values) + case pbv1.ValueTypeStrArr: + var values []string + bb := bigValuePool.Generate() + var err error + for len(value) > 0 { + bb.Buf, value, err = unmarshalVarArray(bb.Buf[:0], value) + if err != nil { + logger.Panicf("unmarshalVarArray failed: %v", err) + } + values = append(values, string(bb.Buf)) + } + return strArrTagValue(values) + default: + logger.Panicf("unsupported value type: %v", valueType) + return nil + } +} + +func int64TagValue(value int64) *modelv1.TagValue { + return &modelv1.TagValue{ + Value: &modelv1.TagValue_Int{ + Int: &modelv1.Int{ + Value: value, + }, + }, + } +} + +func strTagValue(value string) *modelv1.TagValue { + return &modelv1.TagValue{ + Value: &modelv1.TagValue_Str{ + Str: &modelv1.Str{ + Value: value, + }, + }, + } +} + +func binaryDataTagValue(value []byte) *modelv1.TagValue { + data := make([]byte, len(value)) + copy(data, value) + return &modelv1.TagValue{ + Value: &modelv1.TagValue_BinaryData{ + BinaryData: data, + }, + } +} + +func int64ArrTagValue(values []int64) *modelv1.TagValue { + return &modelv1.TagValue{ + Value: &modelv1.TagValue_IntArray{ + IntArray: &modelv1.IntArray{ + Value: values, + }, + }, + } +} + +func strArrTagValue(values []string) *modelv1.TagValue { + return &modelv1.TagValue{ + Value: &modelv1.TagValue_StrArray{ + StrArray: &modelv1.StrArray{ + Value: values, + }, + }, + } +} + +// nolint: unused +func mustDecodeFieldValue(valueType pbv1.ValueType, value []byte) *modelv1.FieldValue { + if value == nil { + switch valueType { + case pbv1.ValueTypeInt64, pbv1.ValueTypeFloat64: + logger.Panicf("int64 and float64 can't be nil") + case pbv1.ValueTypeStr: + return pbv1.EmptyStrFieldValue + case pbv1.ValueTypeBinaryData: + return pbv1.EmptyBinaryFieldValue + default: + return pbv1.NullFieldValue + } + } + switch valueType { + case pbv1.ValueTypeInt64: + return int64FieldValue(convert.BytesToInt64(value)) + case pbv1.ValueTypeFloat64: + return float64FieldValue(convert.BytesToFloat64(value)) + case pbv1.ValueTypeStr: + return strFieldValue(string(value)) + case pbv1.ValueTypeBinaryData: + return binaryDataFieldValue(value) + default: + logger.Panicf("unsupported value type: %v", valueType) + return nil + } +} + +// nolint: unused +func int64FieldValue(value int64) *modelv1.FieldValue { + return &modelv1.FieldValue{ + Value: &modelv1.FieldValue_Int{ + Int: &modelv1.Int{ + Value: value, + }, + }, + } +} + +// nolint: unused +func float64FieldValue(value float64) *modelv1.FieldValue { + return &modelv1.FieldValue{ + Value: &modelv1.FieldValue_Float{ + Float: &modelv1.Float{ + Value: value, + }, + }, + } +} + +// nolint: unused +func strFieldValue(value string) *modelv1.FieldValue { + return &modelv1.FieldValue{ + Value: &modelv1.FieldValue_Str{ + Str: &modelv1.Str{ + Value: value, + }, + }, + } +} + +// nolint: unused +func binaryDataFieldValue(value []byte) *modelv1.FieldValue { + data := make([]byte, len(value)) + copy(data, value) + return &modelv1.FieldValue{ + Value: &modelv1.FieldValue_BinaryData{ + BinaryData: data, + }, + } +} + +type queryResult struct { + sidToIndex map[common.SeriesID]int + data []*blockCursor + pws []*partWrapper + loaded bool + orderByTS bool + ascTS bool +} + +func (qr *queryResult) Pull() *pbv1.Result { + if !qr.loaded { + if len(qr.data) == 0 { + return nil + } + // TODO:// Parallel load + tmpBlock := generateBlock() + defer releaseBlock(tmpBlock) + for i := 0; i < len(qr.data); i++ { + if !qr.data[i].loadData(tmpBlock) { + qr.data = append(qr.data[:i], qr.data[i+1:]...) + i-- + } + if qr.orderByTimestampDesc() { + qr.data[i].idx = len(qr.data[i].timestamps) - 1 + } + } + qr.loaded = true + heap.Init(qr) + } + if len(qr.data) == 0 { + return nil + } + if len(qr.data) == 1 { + r := &pbv1.Result{} + bc := qr.data[0] + bc.copyAllTo(r) + qr.data = qr.data[:0] + return r + } + return qr.merge() +} + +func (qr *queryResult) Release() { + for i, v := range qr.data { + releaseBlockCursor(v) + qr.data[i] = nil + } + qr.data = qr.data[:0] + for i := range qr.pws { + qr.pws[i].decRef() + } + qr.pws = qr.pws[:0] +} + +func (qr queryResult) Len() int { + return len(qr.data) +} + +func (qr queryResult) Less(i, j int) bool { + leftTS := qr.data[i].timestamps[qr.data[i].idx] + rightTS := qr.data[j].timestamps[qr.data[j].idx] + leftVersion := qr.data[i].p.partMetadata.Version + rightVersion := qr.data[j].p.partMetadata.Version + if qr.orderByTS { + if leftTS == rightTS { + if qr.data[i].bm.seriesID == qr.data[j].bm.seriesID { + // sort version in descending order if timestamps and seriesID are equal + return leftVersion > rightVersion + } + // sort seriesID in ascending order if timestamps are equal + return qr.data[i].bm.seriesID < qr.data[j].bm.seriesID + } + if qr.ascTS { + return leftTS < rightTS + } + return leftTS > rightTS + } + leftSIDIndex := qr.sidToIndex[qr.data[i].bm.seriesID] + rightSIDIndex := qr.sidToIndex[qr.data[j].bm.seriesID] + if leftSIDIndex == rightSIDIndex { + if leftTS == rightTS { Review Comment: Remove it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
