hanahmily commented on code in PR #479:
URL:
https://github.com/apache/skywalking-banyandb/pull/479#discussion_r1659419709
##########
api/proto/banyandb/database/v1/schema.proto:
##########
@@ -95,6 +96,8 @@ message FieldSpec {
EncodingMethod encoding_method = 3 [(validate.rules).enum.defined_only =
true];
// compression_method indicates how to compress data during writing
CompressionMethod compression_method = 4 [(validate.rules).enum.defined_only
= true];
+ // aggregate_function indicates how to aggregate data
+ model.v1.AggregationFunction aggregate_function = 5;
Review Comment:
Our plan is to use the same functions to handle these scenarios. These
functions are pure computing logic without any context related to the processes
they are in.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
