hanahmily commented on code in PR #479:
URL:
https://github.com/apache/skywalking-banyandb/pull/479#discussion_r1701095033
##########
api/proto/banyandb/model/v1/common.proto:
##########
@@ -77,3 +77,17 @@ enum AggregationFunction {
AGGREGATION_FUNCTION_COUNT = 4;
AGGREGATION_FUNCTION_SUM = 5;
}
+
+enum MeasureAggregate {
+ MEASURE_AGGREGATE_UNSPECIFIED = 0;
+ MEASURE_AGGREGATE_MIN = 1;
+ MEASURE_AGGREGATE_MAX = 2;
+ MEASURE_AGGREGATE_COUNT = 3;
+ MEASURE_AGGREGATE_SUM = 4;
+ MEASURE_AGGREGATE_AVG = 5;
+ MEASURE_AGGREGATE_PERCENT = 6;
+ MEASURE_AGGREGATE_RATE = 7;
+ MEASURE_AGGREGATE_HISTOGRAM = 8;
+ MEASURE_AGGREGATE_PERCENTILE2 = 9;
Review Comment:
@wu-sheng Would you mind if we call it 'percentile2', which aligns with the
name defined in OAP?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
