fzdwx commented on code in PR #188:
URL: https://github.com/apache/skywalking-go/pull/188#discussion_r1675757309
##########
plugins/mux/serve_interceptor.go:
##########
@@ -58,8 +57,19 @@ func (n *ServeHTTPInterceptor) AfterInvoke(invocation
operator.Invocation, resul
return nil
}
+func newWriterWrapper(rw interface{}) *writerWrapper {
+ writer := rw.(http.ResponseWriter)
+ hijacker := rw.(http.Hijacker)
Review Comment:
> Is any possible the agent will got panic when cast failure? Please do more
explain on this.
If it were the original `http.ResponseWirter` then the panic would
definitely not happen.
https://github.com/golang/go/blob/master/src/net/http/server.go#L2155
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
